Upgrade to play-json 3.x #300
Conversation
|
I'll review this as soon as possible, but I am off work tomorrow! I'd like to get #299 merged before merging this PR. |
I did this in the hope that we could add Scala 3 support at this point, but that's currently blocked by commercial-shared and content-api-client which don't have Scala 3 support.
|
This looks good, I'm going to merge and release this, though in terms of rollout to the projects that consume this library ( There are 3 projects that have not yet upgraded to v4.0.6, see issue #301 - until |
|
This has been released as v4.0.9, using the new Note that the initial run of the release with I was able to work around this with 2d1ad72 (disabling the automated-compatibility-assessment), performing a release, and then applying 7c08a2f, to re-enable the automated-compatibility-assessment. |
The first release failed https://github.com/guardian/targeting-client/actions/runs/7299624335/job/19892813494 because in #37 we changed the coordinates of the artifact so now `sbt-version-policy` plugin cannot find the previous version. Once we perform a release we will put back this line. See also guardian/facia-scala-client#300 (comment) Co-authored-by: Roberto Tyley <[email protected]>
Re-raising @mkurz's PR:
It has to be raised by someone in The Guardian organisation for the build to run.
It is required for:
What does this change?
Adds fapi-client and facia-json Play 3 support.
How to test
Compiles successfully locally with the SNAPSHOT version in this frontend PR:
Deployment