Skip to content

Added 018 react context api #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverlloyd merged 2 commits into from
Oct 8, 2019
Merged

Added 018 react context api #807

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bee576b
Added 018 react context api
oliverlloyd Oct 7, 2019
09e997f
Added `.md` extension
oliverlloyd Oct 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions docs/architecture/018-react-context-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# React Context API

## Context

We don't use any state management in dotcom at the moment and this means props have to be
explicitly passed around; this can lead to 'prop drilling'.
[This PR](https://github.com/guardian/dotcom-rendering/pull/801) was a spike to demonstrate using
the react context api to extract the `edition` property to prevent this.

## Decision

- Our component tree is shallow so we shouldn't implement any 'magic' that
steps away from having explicit props showing where and what data a component is using.
- This decision should be revisited as the codebase grows.

## Status

Approved