Fix cookies not saving in viewer.gutools.co.uk #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GHaberis
reviewed
Jan 28, 2020
GHaberis
reviewed
Jan 28, 2020
ripecosta
force-pushed
the
rc/preview-cookie-saving
branch
from
30f7306 to
f37b6c9
Compare
GHaberis
reviewed
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where cookies were not being saved when accessing viewer.gutools.co.uk.
This was happening because we never accounted for domains using a second level domain such as
viewer.gutools.co.uk. So when slicing the full domain to remove subdomains we were getting.co.ukand setting it as the cookie domain, which the browser ignored.