Merge v2 refactors into master #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename canShow to shouldShow
Comment out PECR logic in stateChanged()
Fix parameter used when calling setConsentState
Unified build process
GHaberis
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had created the
v2.0-rcbranch to keep all the refactoring we were doing for v2.0 release and still keep v1.x.x available in case we needed to A/B test any changes. We are now confident we won't be testing any changes until the release of v2.0 together with a new CMP UI so we are safe to merge this branch into master. All the commits in this branch were added through PRs.List of PRs included in this brach:
#39: Introduce CMP Component to the library
#40: Pull the temporary legacy cookie reading code into cookie.ts
#42: CMP restructure Phase 2
#43: CMP restructure Phase 3
#44: CMP restructure phase 4
#45: CMP restructure phase 5
#46: Removing unnecessary exports
#48: CMP restructure phase 6
#49: Introduce FontsContext (CMP restructure)
#50: Call state change handlers only when consent is not the same
#51: Rename canShow to shouldShow
#52: Comment out PECR logic in stateChanged()
#53: Fix parameter used when calling setConsentState
#54: Unified build process