Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add parameter helper functions on GuStack #92

Merged
merged 3 commits into from
Feb 17, 2021
Merged

feat: add parameter helper functions on GuStack #92

merged 3 commits into from
Feb 17, 2021

Commits on Feb 17, 2021

  1. add parameter helper functions on GuStack 

    Helper functions to get/set parameters on the GuStack. An `Error` is thrown when getting a parameter that hasn't been set; this is to catch the error at compile time.
    @akash1810
    akash1810 committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    8dff3e9 View commit details
    Browse the repository at this point in the history

  2. remove explicit testing of GuStageParameter and GuStackParameter 

    A GuParameter now relies on a function from GuStack, as GuStageParameter and GuStackParameter are automatically added to a GuStack, we cannot explicitly test them now as its recursuve.

Remove them in favour of a slightly implicit test in stack.test.ts.
    @akash1810
    akash1810 committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    dcac71d View commit details
    Browse the repository at this point in the history

  3. remove stack and stage private fields from GuStack 

    These can be replaced with the new getParam helper.
    @akash1810
    akash1810 committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    40292cb View commit details
    Browse the repository at this point in the history