feat!: Make mandatory dns constructor in ec2-app pattern #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: changed the properties in GuEc2AppProps To migrate, change certificateProps to domainNameProps.
|
Request for review is to ask for feedback only at this stage. This cannot be merged for now until the relevant accounts are set up with private resource types. |
|
I'm going to close this as we opted to change the approach in the end (see #913 and #912). Feel free to re-open or add comments to the discussion if you disagree with this @michaelwmcnamara! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
BREAKING CHANGE: changed the properties in GuEc2AppProps
This change adds the ability to automatically setup the DNS with in the EC2App pattern.
Does this change require changes to existing projects or CDK CLI?
Yes: To migrate, change certificateProps to domainNameProps in the EC2App pattern.
Does this change require changes to the library documentation?
The migration guide needs to be updated apropriately:
How to test
run all scripted tests
How can we measure success?
EC2 apps are starting up succesfully and do not need to have their domain names defined in a .yaml file.
Have we considered potential risks?
Accounts that do not have private resource type will not be able to use this version