feat: make Wazuh access security group a singleton #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'd only ever want one of these resources defined in a stack as it can be re-used by anything that needs it. This helps keep the overall size of the template down and thus reduces chance of reaching the file size limits of cloudformation.
akash1810
force-pushed
the
aa-wazuh-singleton
branch
from
db6a680 to
742c674
Compare
|
🎉 This PR is included in version 6.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We'd only ever want one of these resources defined in a stack as it can be re-used by anything that needs it. This helps keep the overall size of the template down and thus reduces chance of reaching the file size limits of cloudformation.
This change also refactors the security groups, splitting them across multiple files to make them easier to reason about.
Reviewing commit by commit might be easiest.
Does this change require changes to existing projects or CDK CLI?
Yes. Usage of the Wazuh security group would need to change.
How to test
See tests.
How can we measure success?
A simpler API and reduced chance of reaching the file size limits of cloudformation
Have we considered potential risks?
n/a