chore: stay on v1 lockfile as CI doesn't have native NPMv7 support #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephengeller
approved these changes
Mar 19, 2021
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
In #335 we moved to a v2 lockfile which is the new format for NPMv7. CI doesn't have native support for NPMv7 yet, so move back to a v1 lockfile.
See #335 (comment) for more information.
As
package-lock.jsondoesn't form part of the bundle published to NPM, I don't think this requires a release of its own.Does this change require changes to existing projects or CDK CLI?
No.
How to test
n/a
How can we measure success?
n/a
Have we considered potential risks?
n/a