Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: further automate release process #235

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Conversation

akash1810
Copy link
Member

@akash1810 akash1810 commented Feb 5, 2021

What does this change?

We use np to orchestrate the publication of a module to NPM. One of the steps np performs is a commit to edit package.json's version.

As we have branch protection enabled for main, we have to raise a PR to get this commit in. Automate this process in the release script as it's pretty boring!

This change checks one has the GitHub CLI installed and raises a PR if it can.

Related https://github.com/guardian/cdk/pull/229/files#r570193715

This is still a stop gap until we have semantic-release or similar in the project.

Does this change require changes to existing projects or CDK CLI?

No.

How to test

Create a release?

How can we measure success?

More automation = less thinking = fewer mistakes!

Have we considered potential risks?

n/a

We use `np` to orchestrate the publication of a module to NPM. One of the steps `np` performs is a commit to edit `package.json`'s `version`.

As we have branch protection enabled for `main`, we have to raise a PR to get this commit in. Automate this process in the release script as it's pretty boring!

This change assumes one has the GitHub CLI installed.
@akash1810 akash1810 requested a review from a team February 5, 2021 13:15
@akash1810 akash1810 merged commit e77721b into main Feb 5, 2021
@akash1810 akash1810 deleted the aa-create-release-pr branch February 5, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants