Update AMI parameter #207
Merged
Update AMI parameter #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR updates the type of the parameter created auto-magically in the
GuAutoscalaingGroupto be aGuAMIParameter. Using this parameter changes theTypevalue toAWS::EC2::Image::Idwhich will restrict the values that can be input, offering better validation.Does this change require changes to existing projects or CDK CLI?
This change will update the parameter anywhere it is currently used which will be seen at deploy time. Given that an invalid value would have caused the deploy to fail, this shouldn't have any effect.
How to test
See the updated unit test and verify that it passes.
How can we measure success?
Better validation of parameter values.