feat: Add parameters getter on GuStack

src/constructs/core/parameters/base.ts

@@ -22,7 +22,6 @@ export class GuParameter extends CfnParameter {
     });
 
     this.id = id;
-    scope.setParam(this);
   }
 }
 

src/constructs/core/stack.test.ts

@@ -6,7 +6,6 @@ import { Queue } from "aws-cdk-lib/aws-sqs";
 import { CfnInclude } from "aws-cdk-lib/cloudformation-include";
 import { ContextKeys, LibraryInfo, TagKeys } from "../../constants";
 import { GuTemplate } from "../../utils/test";
-import { GuParameter } from "./parameters";
 import type { GuStackProps } from "./stack";
 import { GuStack } from "./stack";
 
@@ -53,23 +52,6 @@ describe("The GuStack construct", () => {
     });
   });
 
-  it("should return a parameter that exists", () => {
-    const stack = new GuStack(new App(), "Test", { stack: "test", stage: "TEST" });
-    const testParam = new GuParameter(stack, "MyTestParam", {});
-    stack.setParam(testParam);
-
-    const actual = stack.getParam<GuParameter>("MyTestParam");
-    expect(actual).toBe(testParam);
-  });
-
-  it("should throw on attempt to get a parameter that doesn't exist", () => {
-    const stack = new GuStack(new App(), "Test", { stack: "test", stage: "TEST" });
-
-    expect(() => stack.getParam<GuParameter>("i-do-not-exist")).toThrowError(
-      "Attempting to read parameter i-do-not-exist which does not exist"
-    );
-  });
-
   it("can persist the logicalId for any resource (consumer's POV)", () => {
     class MigratingStack extends GuStack {
       // eslint-disable-next-line custom-rules/valid-constructors -- for testing purposes

src/constructs/core/stack.ts

@@ -1,4 +1,4 @@
-import { Annotations, App, LegacyStackSynthesizer, Stack, Tags } from "aws-cdk-lib";
+import { Annotations, App, CfnParameter, LegacyStackSynthesizer, Stack, Tags } from "aws-cdk-lib";
 import type { CfnElement, StackProps } from "aws-cdk-lib";
 import { Template } from "aws-cdk-lib/assertions";
 import { CfnInclude } from "aws-cdk-lib/cloudformation-include";
@@ -8,7 +8,6 @@ import { ContextKeys, LibraryInfo, TagKeys, TrackingTag } from "../../constants"
 import { gitRemoteOriginUrl } from "../../utils/git";
 import type { StackStageIdentity } from "./identity";
 import type { GuStaticLogicalId } from "./migrating";
-import type { GuParameter } from "./parameters";
 
 export interface GuStackProps extends Omit<StackProps, "stackName"> {
   /**
@@ -62,8 +61,6 @@ export class GuStack extends Stack implements StackStageIdentity {
   private readonly _stack: string;
   private readonly _stage: string;
 
-  private params: Map<string, GuParameter>;
-
   get stage(): string {
     return this._stage;
   }
@@ -88,20 +85,16 @@ export class GuStack extends Stack implements StackStageIdentity {
     Tags.of(this).add(key, value, { applyToLaunchedInstances });
   }
 
-  setParam(value: GuParameter): void {
-    this.params.set(value.id, value);
-  }
-
-  getParam<T extends GuParameter>(key: string): T {
-    if (!this.params.has(key)) {
-      throw new Error(`Attempting to read parameter ${key} which does not exist`);
-    }
-
-    return this.params.get(key) as T;
-  }
-
-  get parameterKeys(): string[] {
-    return Array.from(this.params.keys());
+  /**
+   * Returns all the parameters on this stack.
+   *
+   * @see https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/parameters-section-structure.html
+   */
+  get parameters(): Record<string, CfnParameter> {
+    return this.node
+      .findAll()
+      .filter((construct) => construct instanceof CfnParameter)
+      .reduce((acc, param) => ({ ...acc, [param.node.id]: param as CfnParameter }), {});
   }
 
   // eslint-disable-next-line custom-rules/valid-constructors -- GuStack is the exception as it must take an App
@@ -117,8 +110,6 @@ export class GuStack extends Stack implements StackStageIdentity {
       synthesizer: new LegacyStackSynthesizer(),
     });
 
-    this.params = new Map<string, GuParameter>();
-
     this._stack = stack;
     this._stage = stage.toUpperCase();
 

src/constructs/stack-set/stack-set.ts

@@ -142,7 +142,9 @@ export class GuStackSet extends CfnStackSet {
     const stackSetInstanceParameters = props.stackSetInstanceParameters ?? {};
 
     const params = Object.keys(stackSetInstanceParameters);
-    const undefinedStackSetParams = props.stackSetInstance.parameterKeys.filter((_) => !params.includes(_));
+    const parameterKeys = Object.keys(props.stackSetInstance.parameters);
+
+    const undefinedStackSetParams = parameterKeys.filter((_) => !params.includes(_));
 
     if (undefinedStackSetParams.length !== 0) {
       throw new Error(`There are undefined stack set parameters: ${undefinedStackSetParams.join(", ")}`);