Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove GuSsmParameter #1157

Merged
merged 1 commit into from
Mar 11, 2022
Merged

feat!: remove GuSsmParameter #1157

merged 1 commit into from
Mar 11, 2022

Conversation

nicl
Copy link
Contributor

@nicl nicl commented Mar 11, 2022

What does this change?

GuSSMParameter is a custom resource that allows using SSM parameters within Cloudformation templates.

It is quite complex and is (as best we know) unused. See: #1032 for a wider discussion.

The new preferred approach is simply to either:

  • hardcode stage-specific values in your CDK code (if not secrets/sensitive)
  • use Cloudformation (SSM-type) parameters if values are sensitive

How to test

n/a

How can we measure success?

(Reduced complexity and smaller codebase.)

Have we considered potential risks?

(Breaking change for anyone using this.)

Checklist

  • I have listed any breaking changes, along with a migration path [^1]
  • I have updated the documentation as required for the described changes [^2]

(I don't think we need to make documentation changes here.)

See: #1032

This construct is unused and better alternatives exist.
@nicl nicl requested a review from a team as a code owner March 11, 2022 10:28
@nicl nicl changed the title feat: remove GuSsmParameter feat!: remove GuSsmParameter Mar 11, 2022
Copy link
Member

@akash1810 akash1810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Better than any Wordle score!

@nicl nicl merged commit 351a64f into main Mar 11, 2022
@nicl nicl deleted the nicl/remove-gussmparameter branch March 11, 2022 13:24
@github-actions
Copy link
Contributor

🎉 This PR is included in version 38.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

akash1810 added a commit that referenced this pull request Sep 2, 2022
First introduced in #336 and later removed in #1157,
this change removes some code (and a dependency) for an old custom resource.
@akash1810 akash1810 mentioned this pull request Sep 2, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants