-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
12 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
--- | ||
"@guardian/cdk": patch | ||
--- | ||
|
||
fix(experimental-ec2-pattern): Add buffer to rolling update timeout | ||
|
||
If we consider the health check grace period to be the time it takes the "normal" user data to run, | ||
the rolling update should be configured to be a little longer to cover the additional time spent polling the target group. | ||
|
||
A buffer of 1 minute is somewhat arbitrarily chosen. | ||
Too high a value, then we increase the time it takes to automatically rollback from a failing healthcheck. | ||
Too low a value, then we risk flaky deploys. |