fix: Improve GuAutoScalingGroup's support of a multi-app stack

For consistency with other constructs, suffix the `id` of `GuAutoScalingGroup` with the `app`.
This ensures the logicalId is unique both on the auto-generated path and the `existingLogicalId` path.

Also ensure the app tag is added to the construct.

src/constructs/autoscaling/asg.test.ts

@@ -1,11 +1,13 @@
 import "@aws-cdk/assert/jest";
+import "../../utils/test/jest";
 import { SynthUtils } from "@aws-cdk/assert/lib/synth-utils";
 import { InstanceType, UserData, Vpc } from "@aws-cdk/aws-ec2";
 import { ApplicationProtocol } from "@aws-cdk/aws-elasticloadbalancingv2";
 import { Stack } from "@aws-cdk/core";
 import { Stage } from "../../constants";
-import { simpleGuStackForTesting } from "../../utils/test";
+import { TrackingTag } from "../../constants/library-info";
 import type { SynthedStack } from "../../utils/test";
+import { alphabeticalTags, simpleGuStackForTesting } from "../../utils/test";
 import { GuSecurityGroup } from "../ec2";
 import { GuApplicationTargetGroup } from "../loadbalancing";
 import type { GuAutoScalingGroupProps } from "./asg";
@@ -32,6 +34,44 @@ describe("The GuAutoScalingGroup", () => {
     app: "testing",
   };
 
+  test("Uses the AppIdentity to create the logicalId and tag the resource", () => {
+    const stack = simpleGuStackForTesting();
+    new GuAutoScalingGroup(stack, "MyAutoScalingGroup", defaultProps);
+
+    expect(stack).toHaveResourceOfTypeAndLogicalId(
+      "AWS::AutoScaling::AutoScalingGroup",
+      /MyAutoScalingGroupTesting[A-Z0-9]+/
+    );
+
+    expect(stack).toHaveResource("AWS::AutoScaling::AutoScalingGroup", {
+      Tags: alphabeticalTags([
+        {
+          Key: "App",
+          PropagateAtLaunch: true,
+          Value: "testing",
+        },
+        {
+          Key: "Stack",
+          PropagateAtLaunch: true,
+          Value: "test-stack",
+        },
+        {
+          Key: "Stage",
+          PropagateAtLaunch: true,
+          Value: {
+            Ref: "Stage",
+          },
+        },
+        {
+          Key: "Name",
+          PropagateAtLaunch: true,
+          Value: "Test/MyAutoScalingGroupTesting",
+        },
+        { ...TrackingTag, PropagateAtLaunch: true },
+      ]),
+    });
+  });
+
   test("adds the AMI parameter if no imageId prop provided", () => {
     const stack = simpleGuStackForTesting();
 

src/constructs/autoscaling/asg.ts

@@ -6,7 +6,7 @@ import type { ApplicationTargetGroup } from "@aws-cdk/aws-elasticloadbalancingv2
 import { Stage } from "../../constants";
 import type { GuStack } from "../core";
 import { GuAmiParameter, GuInstanceTypeParameter } from "../core";
-import type { AppIdentity } from "../core/identity";
+import { AppIdentity } from "../core/identity";
 import { GuHttpsEgressSecurityGroup } from "../ec2";
 
 // Since we want to override the types of what gets passed in for the below props,
@@ -104,7 +104,7 @@ export class GuAutoScalingGroup extends AutoScalingGroup {
       securityGroup: GuHttpsEgressSecurityGroup.forVpc(scope, props),
     };
 
-    super(scope, id, mergedProps);
+    super(scope, AppIdentity.suffixText(props, id), mergedProps);
 
     mergedProps.targetGroup && this.attachToApplicationTargetGroup(mergedProps.targetGroup);
 
@@ -117,5 +117,7 @@ export class GuAutoScalingGroup extends AutoScalingGroup {
     cfnAsg.addDeletionOverride("UpdatePolicy");
 
     if (mergedProps.overrideId) cfnAsg.overrideLogicalId(id);
+
+    AppIdentity.taggedConstruct(props, this);
   }
 }

src/utils/test/alphabetical-tags.ts

@@ -1,6 +1,7 @@
 interface Tag {
   Key: string;
   Value: unknown;
+  PropagateAtLaunch?: boolean;
 }
 
 export function alphabeticalTags(tags: Tag[]): Tag[] {