Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug where duplicate certifyVuln values showed on output #1646

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix bug where duplicate certifyVuln values showed on output #1646

merged 1 commit into from
Jan 18, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Jan 18, 2024

Description of the PR

fix bug where duplicate certifyVuln values showed on output when querying for vulnerabilities

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

mlieberman85
mlieberman85 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@mlieberman85 mlieberman85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit c3cdc5a into guacsec:main Jan 18, 2024
8 checks passed
@pxp928 pxp928 deleted the fix-vuln-cli-bug branch January 18, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@mlieberman85 mlieberman85 mlieberman85 approved these changes

@jeffmendoza jeffmendoza Awaiting requested review from jeffmendoza jeffmendoza is a code owner

@lumjjb lumjjb Awaiting requested review from lumjjb

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pxp928 @mihaimaruseac @mlieberman85