Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove s3 from guacone until further testing is done on the collector #1645

Merged
merged 1 commit into from
Jan 17, 2024
Merged

remove s3 from guacone until further testing is done on the collector #1645

merged 1 commit into from
Jan 17, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Jan 17, 2024

Description of the PR

remove s3 from guacone until further testing is done on the collector

Related to issue #1644

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@pxp928 pxp928 mentioned this pull request Jan 17, 2024
Closed
@kodiakhq kodiakhq bot merged commit f99d581 into guacsec:main Jan 17, 2024
8 checks passed
@pxp928 pxp928 deleted the guacone-remove-s3 branch January 17, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@jeffmendoza jeffmendoza jeffmendoza approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pxp928 @mihaimaruseac @jeffmendoza