-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1405] Feature/query filter #1610
Conversation
f36510c
to
8fd1c32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @kanchan-dhamane! This is great stuff!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great. Thank you!
Thanks @pxp928 and @mihaimaruseac for reviewing the PR. This PR doesn't handle the filter on nested keys. filter on keyName
|
Hey @kanchan-dhamane! Yes that would be a valid usecase. We can do that in another PR if that is easier. |
+1 to doing it in a separate PR |
@kanchan-dhamane just need to sign your commits and this will auto-merge. |
294cf29
to
d4e64f0
Compare
Signed-off-by: Kanchan Dhamane <[email protected]>
Signed-off-by: Kanchan Dhamane <[email protected]>
…dates expectArtifactsQ1.json file Signed-off-by: Kanchan Dhamane <[email protected]>
Signed-off-by: Kanchan Dhamane <[email protected]>
d4e64f0
to
731cb11
Compare
I've signed the previous commits. Thanks @pxp928! |
created issue to capture this: #1615 |
* query filter initial commit Signed-off-by: Kanchan Dhamane <[email protected]> * query filter - removes the comment from the directive resolver file Signed-off-by: Kanchan Dhamane <[email protected]> * chore[query-filter] - adds the new line at the end of e2e file and updates expectArtifactsQ1.json file Signed-off-by: Kanchan Dhamane <[email protected]> * chore[query-filter] - updates the e2e file Signed-off-by: Kanchan Dhamane <[email protected]> --------- Signed-off-by: Kanchan Dhamane <[email protected]> Co-authored-by: Kanchan Dhamane <[email protected]>
Description of the PR
Fixes - #1405
Adds a custom GraphQL directive to filter results using two options
contains
andstartswith
example-