Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update key methods to use a non-cryptographic hash function. #1559

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

jeffmendoza
Copy link
Collaborator

Some key-value stores (TiKV) have a size limit on keys. So just concatenating all the fields for each node will overflow it. Use a NCHF to hash the key.

The stable memmap used for test sorts on keys. Since the keys changed the expected order in some unit tests were rearranged.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Some key-value stores (TiKV) have a size limit on keys. So just concatinating
all the fields for each node will overflow it. Use a NCHF to hash the key.

Signed-off-by: Jeff Mendoza <[email protected]>
@kodiakhq kodiakhq bot merged commit 2b1e1ae into guacsec:main Dec 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants