Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix queryVulnsViaVulnNodeNeighbors to check for certifyVex edges #1540

Merged
merged 9 commits into from
Dec 27, 2023

Conversation

ridhoq
Copy link
Contributor

@ridhoq ridhoq commented Nov 29, 2023

Description of the PR

queryVulnsViaVulnNodeNeighbors now searches for certifyVex edges

Fixes #1539

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost on the right path :). Thanks for the PR!

cmd/guacone/cmd/vulnerability.go Outdated Show resolved Hide resolved
cmd/guacone/cmd/vulnerability.go Outdated Show resolved Hide resolved
@pxp928
Copy link
Collaborator

pxp928 commented Nov 30, 2023

let me know if that makes sense, I can elaborate more if needed.

@ridhoq ridhoq requested a review from pxp928 December 4, 2023 20:38
@pxp928
Copy link
Collaborator

pxp928 commented Dec 8, 2023

@ridhoq can you rebase this? Thanks!

@ridhoq
Copy link
Contributor Author

ridhoq commented Dec 8, 2023

@ridhoq can you rebase this? Thanks!

@pxp928 should be good to go now

Copy link
Collaborator

@jeffmendoza jeffmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! some minor comments.

cmd/guacone/cmd/vulnerability.go Outdated Show resolved Hide resolved
cmd/guacone/cmd/vulnerability.go Outdated Show resolved Hide resolved
@pxp928
Copy link
Collaborator

pxp928 commented Dec 12, 2023

FYI @ridhoq made some updates in my PR to the vulnerability query. That will remove unnecessary calls to neighbors query: #1582

@kodiakhq kodiakhq bot merged commit d825ccf into guacsec:main Dec 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] guacone query vuln does not return VEX statements when a vulnerability ID is passed in
3 participants