Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redis and TiKV kv stores #1502

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Add Redis and TiKV kv stores #1502

merged 3 commits into from
Nov 15, 2023

Conversation

jeffmendoza
Copy link
Collaborator

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@jeffmendoza
Copy link
Collaborator Author

Looks like the TiKV client doesn't support 32-bit as well. I'll update

@kodiakhq kodiakhq bot merged commit 1fb5ee9 into guacsec:main Nov 15, 2023
8 checks passed
nathannaveen pushed a commit to nathannaveen/guac that referenced this pull request Nov 16, 2023
* Add Redis and TiKV kv stores

Signed-off-by: Jeff Mendoza <[email protected]>

* Only use TiKV on 64 bit

Signed-off-by: Jeff Mendoza <[email protected]>

* Also don't built tikv for darwin.

Signed-off-by: Jeff Mendoza <[email protected]>

---------

Signed-off-by: Jeff Mendoza <[email protected]>
Signed-off-by: nathannaveen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants