Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Included option to run integration tests locally #1361

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Included option to run integration tests locally #1361

merged 3 commits into from
Oct 30, 2023

Conversation

naveensrinivasan
Copy link
Contributor

@naveensrinivasan naveensrinivasan commented Oct 5, 2023 •
edited
Loading

Description of the PR

  • Included an option to run integration tests locally.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@naveensrinivasan naveensrinivasan changed the title Included option to integration tests locally Included option to run integration tests locally Oct 5, 2023
lumjjb
lumjjb reviewed Oct 6, 2023
View reviewed changes
Makefile Show resolved Hide resolved
lumjjb
lumjjb reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making the change - 1 last minor request to replace the sleep with a check if graphQL is up

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@naveensrinivasan naveensrinivasan force-pushed the naveen/int-docker-compose branch 3 times, most recently from 8ed4e11 to 5840822 Compare October 11, 2023 14:21
@naveensrinivasan
Included option to integration tests locally
a2002a7 
- Included an option to run integration tests locally.

Signed-off-by: naveensrinivasan <[email protected]>
@naveensrinivasan
Improve integration test setup
8262c4b 
Signed-off-by: naveensrinivasan <[email protected]>
@naveensrinivasan
Code review comments.
a97b43a 
Signed-off-by: naveensrinivasan <[email protected]>
@naveensrinivasan
Copy link
Contributor Author

@lumjjb A friendly ping

@kodiakhq kodiakhq bot merged commit 2af1cc4 into guacsec:main Oct 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@lumjjb lumjjb lumjjb approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naveensrinivasan @mihaimaruseac @lumjjb