Is There a Difference Between Structs

[nathannaveen]

Hi, I was trying to test pkg/certifier/osv/internal/osv_query/osv_query.go and saw that there are the structs, BatchedResponse and HydratedBatchedResponse:

guac/pkg/certifier/osv/internal/osv_query/osv_query.go

Lines 80 to 88 in 3dd8931

	// BatchedResponse represents an unhydrated batched response from OSV.
	type BatchedResponse struct {
	Results []MinimalResponse `json:"results"`
	}
	// HydratedBatchedResponse represents a hydrated batched response from OSV.
	type HydratedBatchedResponse struct {
	Results []Response `json:"results"`
	}

HydratedBatchedResponse only has Results []Response `json:"results"` in it, and BatchedResponse has Results []MinimalResponse `json:"results"` in it.

Response is:

type Response struct {
	Vulns []osv.Entry `json:"vulns"`
}

And MinimalResponse is:

type MinimalResponse struct {
	Vulns []osv.Entry `json:"vulns"`
}

So what makes HydratedBatchedResponse and BatchedResponse different, is there a reason they are two different structs?

[nathannaveen]

cc @pxp928, 👀

[pxp928]

@nathannaveen This file was copied over (and slightly modified) from an upstream project (now OSV Scanner). I did create another issue #323 to track that we eventually remove this from GUAC (this issue jogged my memory that I forgot to do that. Thanks for that!). Feel free to remove the redundant structs but overall the whole file will be removed in the near future once I speak with the OSV Scanner maintainers. Currently there is a comment on the file for other that view it in the future:

guac/pkg/certifier/osv/internal/osv_query/osv_query.go

Lines 16 to 19 in 3dd8931

	// This package is currently copied from
	// https://github.com/google/osv-scanner/blob/main/internal/osv/osv.go.
	// Currently this is not exposed by the upstream project. Once it is
	// exposed, this will be removed.