Documentation of RestAPI integration from v0.4.0 - v0.6.0 #164
Conversation
✅ Deploy Preview for resonant-wisp-1a517a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
@Ritesh-Udgata welcome to GUAC. This is a great start! I've left a few comments, and I'll ask others to give it a fact check as well.
There are two things I know you'll need to do:
- Fix the formatting (see the comment about "prettier" in the readme.
- Add a "Signed-off by: " line in your commit.
If you need help with anything, please join us on [https://guac.sh/community](OpenSSF's Slack)
|
All changes Done 👍 |
|
Thanks! Can you update the endpoints as explained here #164 (comment)? |
|
Endpoints are now updated with reference to guacsec/guac#2217 |
Signed-off-by: Ritesh <[email protected]>
Ritesh-Udgata
force-pushed
the
restAPIdoc
branch
from
aabc735
to
a61a7a7
Compare
|
Squashed all commits. Added Signed off. Fixed typo. 👍 |
There was a problem hiding this comment.
Looks good to me, thanks! I'm going to hold off on merging this since the changes in guacsec/guac#2217 aren't merged yet, but I'll apply the hacktoberfest-accepted label so you'll get credit for it, if that's important to you. Thanks again for your contribution!
funnelfiasco
added
blocked
|
@Ritesh-Udgata One more comment! The documentation is missing the |
Signed-off-by: Ritesh <[email protected]>
|
Mentioned recent version updates that integrated restAPI into guac and provides insights about endpoints, authentication, error handling and contribution methodology.
close #127