Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webrick dependency #158

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Remove webrick dependency #158

merged 1 commit into from
Oct 10, 2024

Conversation

funnelfiasco
Copy link
Collaborator

As far as I can tell, this isn't actually used anywhere, so we avoid a CVE by dropping it. Upstream says it's not for use in production anyway.

As far as I can tell, this isn't actually used anywhere, so we avoid a
[CVE](https://github.com/guacsec/guac-docs/security/dependabot/12) by dropping
it. Upstream says it's [not for use in production](ruby/webrick#145 (comment))
anyway.

Signed-off-by: Ben Cotton <[email protected]>
@funnelfiasco funnelfiasco added the dependencies Pull requests that update a dependency file label Oct 8, 2024
Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for resonant-wisp-1a517a ready!

Name Link
🔨 Latest commit a9eedf3
🔍 Latest deploy log https://app.netlify.com/sites/resonant-wisp-1a517a/deploys/67055aa0bc4e620008f043b7
😎 Deploy Preview https://deploy-preview-158--resonant-wisp-1a517a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@funnelfiasco
Copy link
Collaborator Author

@hayleycd if you're still around, it looks like you introduced this dependency as part of 2a38766. Is there something non-obvious I'm missing?

@lumjjb
Copy link
Contributor

lumjjb commented Oct 10, 2024

preview still seems to work. let's merge it and revert if something goes wrong.

@lumjjb lumjjb merged commit dcb29f2 into guacsec:main Oct 10, 2024
6 checks passed
@funnelfiasco funnelfiasco deleted the webrick branch October 18, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants