Allow chaining expressions with Closure objects

[jf2048]

I had to change ClosureExpression::with_closure to expand out the generic parameters, it could be changed back depending on this: rust-lang/rust#83701

Also includes some docs fixes.

[SeaDve]

I think chain_gclosure may be clearer

[jf2048]

That may not be straightforward as the macro was changed to just closure!. Maybe it could be chain_with_closure, but that also seems confusing.

[bilelmoussaoui]

Maybe rename the first chain_closure to chain_callback & keep this one as chain_closure?

[SeaDve]

I just realized that it was named chain_closure before since it chains a ClosureExpression, but something like chain_closure_with_closure is a weird name

[bilelmoussaoui]

I just realized that it was named chain_closure before since it chains a ClosureExpression, but something like chain_closure_with_closure is a weird name

Well the ClosureExpression should only take a glib::Closure but we provide a helper constructor that takes a callback. So it's fine to not name it chain_closure if it's documented properly. The double chain_closure_with_closure is definitely not great

[SeaDve]

I see, maybe chain_closure and chain_closure_with_callback ?

[bilelmoussaoui]

I see, maybe chain_closure and chain_closure_with_callback ?

No strong opinions here, @sdroege ?:)

[sdroege]

Seems fine either way. Ask your favorite random number generator and go with that :)

[bilelmoussaoui]

I see, maybe chain_closure and chain_closure_with_callback ?

Let's go with this one then

[SeaDve]

semi related to pr, maybe the ClosureExpression
's constructors could also be renamed to new and with_callback for coherence

[jf2048]

This is updated with the name changes, but it's a bit awkward with the recent addition of RustClosure because now it always has to be closure!( ... ).into().

[bilelmoussaoui]

Make it take a RustClosure ?

[sdroege]

It probably has to for type-safety reasons anyway.

[jf2048]

I changed it to RustClosure, if someone wants to add another function that takes just Closure it should probably be unsafe anyway.

[bilelmoussaoui]

other than the cargo fmt, lgtm

[bilelmoussaoui]

Thanks!