Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsafe interface requirement for into ptr conversion #1666

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

BiagioFesta
Copy link
Contributor

@BiagioFesta BiagioFesta commented Feb 24, 2025

Fixes: #1663

For reviewers to focus on

Beside "sed changes", manual changes also include:

  • impl IntoGlibPtr<*mut c_char> for GString requires inner unsafe block as calling extern "C" functions
  • pub unsafe trait RefCounted::into_raw also changed removing unsafe requirement.
  • This is a API (breaking/major) change

@sdroege sdroege merged commit 2967438 into gtk-rs:main Feb 25, 2025
47 of 48 checks passed
@sdroege
Copy link
Member

sdroege commented Feb 25, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Remove unsafe for into pointer conversion (rust edition 2024)
2 participants