Add additional type bounds to Impl traits #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felinira
commented
Sep 24, 2024
felinira
commented
Sep 24, 2024
sdroege
reviewed
Sep 29, 2024
felinira
force-pushed
the
wip/impl-trait-bounds
branch
2 times, most recently
from
f30a7aa
to
bf09d82
Compare
|
I removed all sealed traits except for the one for ObjectImplExt, which I am unsure about. But I don't see much harm in that one. |
What's different with that one? Seems like the others to me and should be fine with just the |
felinira
force-pushed
the
wip/impl-trait-bounds
branch
from
bf09d82
to
03bdfd2
Compare
You're right. I was thinking because you don't need to specify them in the wrapper macro, but that's unrelated. |
felinira
force-pushed
the
wip/impl-trait-bounds
branch
from
03bdfd2
to
d997c25
Compare
|
As discussed on matrix, I added additional |
felinira
force-pushed
the
wip/impl-trait-bounds
branch
from
d997c25
to
0575a08
Compare
sdroege
previously approved these changes
Sep 30, 2024
sdroege
force-pushed
the
wip/impl-trait-bounds
branch
from
0575a08
to
f065259
Compare
|
Some failing tests :) |
felinira
force-pushed
the
wip/impl-trait-bounds
branch
from
f065259
to
7e1f8dc
Compare
Remove the Sealed traits, as they are now unnecessary.
felinira
force-pushed
the
wip/impl-trait-bounds
branch
from
7e1f8dc
to
07dbf34
Compare
sdroege
approved these changes
Oct 3, 2024
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1515