gio: Add subclassing support to AppLaunchContext & FileMonitor #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bilelmoussaoui
force-pushed
the
bilelmoussaoui/gio-subclass
branch
from
2fb69cd
to
ff2f049
Compare
bilelmoussaoui
force-pushed
the
bilelmoussaoui/gio-subclass
branch
from
ff2f049
to
d191b45
Compare
sdroege
reviewed
Feb 20, 2023
| self.parent_to_tokens() | ||
| } | ||
|
|
||
| fn from_tokens(tokens: &[String], version: i32) -> Result<Icon, Error> { |
There was a problem hiding this comment.
This and above is a StrV if you want to avoid all the copying
sdroege
reviewed
Feb 20, 2023
sdroege
reviewed
Feb 20, 2023
| use crate::{subclass::prelude::*, File, FileMonitor, FileMonitorEvent}; | ||
| use glib::{prelude::*, translate::*}; | ||
|
|
||
| pub trait FileMonitorImpl: ObjectImpl { |
There was a problem hiding this comment.
Today it is not for sure. My intention is to cover up whatever APIs we can manually to have a better understanding of what is needed for an automatically generated of the subclassing code in the future
There was a problem hiding this comment.
I mean, is this actually intended to be subclasses? The API exposed here looks quite incomplete for implementing a new file monitor
sdroege
reviewed
Feb 20, 2023
| let instance = &*(ptr as *mut T::Instance); | ||
| let imp = instance.imp(); | ||
|
|
||
| imp.launch_failed(&GString::from_glib_borrow(startup_id)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.