Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the layout tests #1409

Merged
merged 3 commits into from
Nov 30, 2022
Merged

fix the layout tests #1409

merged 3 commits into from
Nov 30, 2022

Conversation

jf2048
Copy link
Member

@jf2048 jf2048 commented Nov 30, 2022

Part of gtk-rs/gtk-rs-core#64, only really needed to pick up gio-unix-2.0. Also fixes those warnings about PACKAGES, etc being unused on windows

@jf2048 jf2048 marked this pull request as draft November 30, 2022 16:31
@jf2048 jf2048 marked this pull request as ready for review November 30, 2022 16:35
@jf2048
Copy link
Member Author

jf2048 commented Nov 30, 2022

BTW I think this means the tests will still just be broken on windows due to not having gio-unix? Related to #1052

@sdroege
Copy link
Member

sdroege commented Nov 30, 2022

Yes

@jf2048 jf2048 changed the title support multiple package names for pkg-config in generated tests fix the layout tests Nov 30, 2022
@sdroege sdroege merged commit 6ec1537 into gtk-rs:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants