Skip to content

CPS onRequest handler: path-based fallback for direct transport.request() calls#3

Closed
gsoldevila wants to merge 6 commits intocore-cps-onrequest-fallbackfrom
core-cps-direct-transport
Closed

CPS onRequest handler: path-based fallback for direct transport.request() calls#3
gsoldevila wants to merge 6 commits intocore-cps-onrequest-fallbackfrom
core-cps-direct-transport

Conversation

@gsoldevila
Copy link
Copy Markdown
Owner

@gsoldevila gsoldevila commented Feb 18, 2026

Summary

Direct transport calls

Mitigates https://github.com/elastic/kibana-team/issues/2886

Some callers use transport.request() directly (e.g. ES|QL /_query) and bypass the high-level client. Those calls have no meta.acceptedParams, so the CPS onRequest handler did not apply project_routing.

This PR adds a path-based fallback when acceptedParams is missing: if the request path is CPS-sensitive (e.g. /_search, /_query, /_msearch), the handler still injects project_routing. A debounced warning (at most once per hour) is logged when a direct transport.request() hits a CPS-sensitive path to encourage moving to the high-level API.

Stacked on elastic#253697 (branch core-cps-onrequest-fallback).

Made with Cursor

gsoldevila and others added 6 commits February 18, 2026 13:49
@gsoldevila @cursoragent
Add path-based fallback for CPS project_routing in direct transport.r…
bab1981 
…equest() calls

Co-authored-by: Cursor <cursoragent@cursor.com>
@gsoldevila
Formatting and claryfing comment
6d192f5
@gsoldevila @cursoragent
Read CPS config from configService, remove setCpsFeatureFlag setter
678b71a 
The ElasticsearchService now reads the cps.cpsEnabled config directly
from the configService during setup, removing the need for the
setCpsFeatureFlag setter pattern. The CpsRequestHandler is only
instantiated in serverless mode, and the onRequest handler is only
passed to ClusterClient when applicable.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gsoldevila
Address PR feedback
3313f7d
@gsoldevila @cursoragent
Extract direct transport fallback to separate PR (remove from this br…
53ada73 
…anch)

Co-authored-by: Cursor <cursoragent@cursor.com>
@gsoldevila @cursoragent
Add path-based fallback for CPS project_routing in direct transport.r…
21272f8 
…equest() calls

Co-authored-by: Cursor <cursoragent@cursor.com>
@gsoldevila gsoldevila force-pushed the core-cps-onrequest-fallback branch from 6e26d80 to dfda0dc Compare February 19, 2026 15:21
@gsoldevila
Copy link
Copy Markdown
Owner Author

gsoldevila commented Mar 13, 2026

Ideally we should replace the low level transport calls with higher level calls that contain the correct metadata.

@gsoldevila gsoldevila closed this Mar 13, 2026
gsoldevila pushed a commit that referenced this pull request Mar 27, 2026
@adcoelho @kibanamachine
[Alerting V2] bulk get alert actions (elastic#258353)
aad9636 
Closes elastic#258317

## Summary

The alert episodes table needs to display episode status for each row.

To build that UI, we needed a bulk-get API for alert actions.

### Testing

<details> <summary>Start by posting some mock action data.</summary>

```
POST .alerting-actions/_bulk
{"create":{}}
{"@timestamp":"2026-03-18T08:00:00.000Z","last_series_event_timestamp":"2026-03-18T07:55:00.000Z","actor":"user-1","action_type":"ack","group_hash":"gh-1","episode_id":"ep-001","rule_id":"rule-1"}
{"create":{}}
{"@timestamp":"2026-03-18T08:10:00.000Z","last_series_event_timestamp":"2026-03-18T07:55:00.000Z","actor":"user-1","action_type":"snooze","group_hash":"gh-1","episode_id":"ep-001","rule_id":"rule-1"}
{"create":{}}
{"@timestamp":"2026-03-18T08:30:00.000Z","last_series_event_timestamp":"2026-03-18T07:55:00.000Z","actor":"user-2","action_type":"deactivate","group_hash":"gh-2","episode_id":"ep-002","rule_id":"rule-1","reason":"Known maintenance window"}
{"create":{}}
{"@timestamp":"2026-03-18T08:45:00.000Z","last_series_event_timestamp":"2026-03-18T07:55:00.000Z","actor":"user-2","action_type":"ack","group_hash":"gh-2","episode_id":"ep-002","rule_id":"rule-1"}
{"create":{}}
{"@timestamp":"2026-03-18T09:00:00.000Z","last_series_event_timestamp":"2026-03-18T08:50:00.000Z","actor":"user-1","action_type":"ack","group_hash":"gh-3","episode_id":"ep-003","rule_id":"rule-2"}
{"create":{}}
{"@timestamp":"2026-03-18T09:15:00.000Z","last_series_event_timestamp":"2026-03-18T08:50:00.000Z","actor":"user-1","action_type":"unack","group_hash":"gh-3","episode_id":"ep-003","rule_id":"rule-2"}
{"create":{}}
{"@timestamp":"2026-03-18T09:30:00.000Z","last_series_event_timestamp":"2026-03-18T09:20:00.000Z","actor":"user-3","action_type":"snooze","group_hash":"gh-4","episode_id":"ep-004","rule_id":"rule-2"}
{"create":{}}
{"@timestamp":"2026-03-18T09:50:00.000Z","last_series_event_timestamp":"2026-03-18T09:20:00.000Z","actor":"user-3","action_type":"unsnooze","group_hash":"gh-4","episode_id":"ep-004","rule_id":"rule-2"}
{"create":{}}
{"@timestamp":"2026-03-18T10:00:00.000Z","last_series_event_timestamp":"2026-03-18T09:50:00.000Z","actor":"user-2","action_type":"deactivate","group_hash":"gh-5","episode_id":"ep-005","rule_id":"rule-3","reason":"Duplicate alert"}
{"create":{}}
{"@timestamp":"2026-03-18T10:20:00.000Z","last_series_event_timestamp":"2026-03-18T09:50:00.000Z","actor":"user-1","action_type":"activate","group_hash":"gh-5","episode_id":"ep-005","rule_id":"rule-3","reason":"Re-enabled after investigation"}
{"create":{}}
{"@timestamp":"2026-03-18T10:30:00.000Z","last_series_event_timestamp":"2026-03-18T10:25:00.000Z","actor":"user-1","action_type":"ack","group_hash":"elasticgh-6","episode_id":"ep-006","rule_id":"rule-3"}
{"create":{}}
{"@timestamp":"2026-03-18T10:45:00.000Z","last_series_event_timestamp":"2026-03-18T10:25:00.000Z","actor":"user-1","action_type":"snooze","group_hash":"elasticgh-6","episode_id":"ep-006","rule_id":"rule-3"}
{"create":{}}
{"@timestamp":"2026-03-18T10:55:00.000Z","last_series_event_timestamp":"2026-03-18T10:25:00.000Z","actor":"user-2","action_type":"deactivate","group_hash":"elasticgh-6","episode_id":"ep-006","rule_id":"rule-3","reason":"Root cause fixed"}
{"create":{}}
{"@timestamp":"2026-03-18T11:00:00.000Z","last_series_event_timestamp":"2026-03-18T10:55:00.000Z","actor":"user-3","action_type":"ack","group_hash":"elasticgh-7","episode_id":"ep-007","rule_id":"rule-4"}
{"create":{}}
{"@timestamp":"2026-03-18T11:30:00.000Z","last_series_event_timestamp":"2026-03-18T11:20:00.000Z","actor":"user-2","action_type":"snooze","group_hash":"elasticgh-8","episode_id":"ep-008","rule_id":"rule-4"}
{"create":{}}
{"@timestamp":"2026-03-18T11:45:00.000Z","last_series_event_timestamp":"2026-03-18T11:20:00.000Z","actor":"user-2","action_type":"ack","group_hash":"elasticgh-8","episode_id":"ep-008","rule_id":"rule-4"}
{"create":{}}
{"@timestamp":"2026-03-18T12:00:00.000Z","last_series_event_timestamp":"2026-03-18T11:50:00.000Z","actor":"user-1","action_type":"deactivate","group_hash":"elasticgh-9","episode_id":"ep-009","rule_id":"rule-5","reason":"Alert storm - suppressing"}
{"create":{}}
{"@timestamp":"2026-03-18T12:10:00.000Z","last_series_event_timestamp":"2026-03-18T11:50:00.000Z","actor":"user-1","action_type":"snooze","group_hash":"elasticgh-9","episode_id":"ep-009","rule_id":"rule-5"}
{"create":{}}
{"@timestamp":"2026-03-18T12:30:00.000Z","last_series_event_timestamp":"2026-03-18T12:20:00.000Z","actor":"user-3","action_type":"ack","group_hash":"elasticgh-10","episode_id":"ep-010","rule_id":"rule-5"}
{"create":{}}
{"@timestamp":"2026-03-18T12:40:00.000Z","last_series_event_timestamp":"2026-03-18T12:20:00.000Z","actor":"user-3","action_type":"unack","group_hash":"elasticgh-10","episode_id":"ep-010","rule_id":"rule-5"}
{"create":{}}
{"@timestamp":"2026-03-18T12:50:00.000Z","last_series_event_timestamp":"2026-03-18T12:20:00.000Z","actor":"user-3","action_type":"ack","group_hash":"elasticgh-10","episode_id":"ep-010","rule_id":"rule-5"}
```

</details>

There are up to 10 episodes with actions, all with ids like `ep-001`.

Query the new route and confirm that the results are as expected.

```
POST kbn:/internal/alerting/v2/alerts/action/_bulk_get
{
  "episode_ids": ["ep-001", "ep-002", "ep-003", "foobar"]
}
```

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gsoldevila