Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Markor more accessible (accessibility) #613

Closed
schulle4u opened this issue Jul 15, 2019 · 5 comments · Fixed by #753
Closed

Make Markor more accessible (accessibility) #613

schulle4u opened this issue Jul 15, 2019 · 5 comments · Fixed by #753
Labels
enhancement good first issue help wanted

Comments

@schulle4u
Copy link

General information

  • App version: 2.0.1 F-Droid
  • System: Android 8.1, Moto G4 Plus

Description

Currently the buttons for text editing and other controls are not accessible to users of assistive technology, e.g. Android Accessibility Suite (TalkBack). Even if announcement of button ID's is turned on in TalkBack settings, most buttons are still recognized as unlabeled, making them quite useless. This could be improvid by adding alternative texts for blind users.
@gsantner gsantner changed the title Improve accessibility Make Markor more accessible (accessibility) Oct 3, 2019
@Andrejkaaa
Copy link

Hi. I'm interested to solve the issue #613. Could you please assign it to me? Thanks.

@gsantner
Copy link
Owner

I think this one needs some discussion. What actions to set and apply.

It's not something that can be fixed per se

@Andrejkaaa
Copy link

Can you please specific which buttons you mean?

@schulle4u
Copy link
Author

@Andrejkaaa mainly the buttons in the editor window. It seems to be a kind of formating toolbar, but all buttons are completely unlabeled, and TalkBack users are not able to read out their functionality, even if reporting of element ID's is turned on in TalkBack settings. Some other buttons such as the one to create a new file at least has an element ID, but it is not very informative. TalkBack reports something like UI_file_system_item_image.

Steffen

@pvagner pvagner mentioned this issue Oct 28, 2019
Merged
gsantner pushed a commit that referenced this issue Nov 1, 2019
@pvagner @gsantner
A11y improvements (fixes #613 , PR #753)
6956e0f 
* a11y: Added content descriptions for toolbar buttons
* a11y: Add content description to the new file button
* a11y: Address review comments by reformatting string resources
* a11y: add a content description to choose format button in the date and time dialog
* a11y: Add content description to the back navigation toolbar button in the settings activity
* a11y: Improve file list experience.

When not considering accessibility the following actions are implemented:
* Clicking an item opens the file
* Long clicking an item selects an item in a multi select list
* Long clicking an image shows a toast with full path to the given item.

When considering accessibility the following applies:
* Image is not exposed to accessibility tools to simplify the navigation flow single navigation step per an item,
* Child nodes are not exposed to accessibility tools in order to provide consistent experience with various screen reading apps,
* Content description for the root node of an item is made up of actual title and description with file / folder / selection state prepended.
gsantner added a commit that referenced this issue Nov 1, 2019
@gsantner
A11y improvements rework, #753 #613
6a5966b
@gsantner
Copy link
Owner

gsantner commented Nov 1, 2019

Thanks @pvagner for your work! In next version Markor will be a lot better in terms of accessibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

A11y improvements pvagner/markor
3 participants
@schulle4u @gsantner @Andrejkaaa