Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support in-content filesearch for encrypted textfiles #1375

Closed
opensource21 opened this issue Jun 26, 2021 · 3 comments · Fixed by #1388
Closed

Support in-content filesearch for encrypted textfiles #1375

opensource21 opened this issue Jun 26, 2021 · 3 comments · Fixed by #1388
Assignees

Comments

@opensource21
Copy link
Contributor

General information

  • App version: 2.7.0
  • System: Android 10

Description

I wonder if it is possible that even encrypted files will be part of the search.
Are there any reason why this isn't implemented? Is the password there not accessible?

@gsantner
Copy link
Owner

gsantner commented Jun 26, 2021

decryption takes lots of performance and as you know, main part of implementation is done at file editor.

Also, if we in future support per-file encryption passwords, this gets impossible. Unless users want to type LOTS OF passwords.

So, only search by filename is available there.

@opensource21
Copy link
Contributor Author

opensource21 commented Jun 26, 2021

Well thanks AES the performance-impact of encryption doesn't seem a problem in my eyes. The question is would you accept a pull-request which adds the feature? The main part is encapsulated in a separate class, so I don't think it's a lot of work.
"per-file encryption passwords" will always be a problem and you can skip them

@opensource21
Copy link
Contributor Author

Opened #1388 so you can see how easily this could be done.

@gsantner gsantner linked a pull request Jul 10, 2021 that will close this issue
@gsantner gsantner changed the title [Feature Request] Enable Filesearch for encrypted files Support in-content filesearch for encrypted textfiles Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants