Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1478 we should copy the TF module into a temporary directory before running tests in parallel #1479

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

wakeful
Copy link
Contributor

@wakeful wakeful commented Dec 5, 2024

Description

fix #1478 we should copy the TF module into a temporary directory before running tests in parallel

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

update AWS RDS tests to execute in a tmp dir fix #1478

Migration Guide

n/a

@wakeful wakeful requested a review from denis256 as a code owner December 5, 2024 16:34
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pass all the tests.

@james03160927
Copy link
Contributor

@wakeful, do you want to update the branch?

…irectory before running tests in parallel
@wakeful wakeful force-pushed the fix-1478-aws-rds-tests branch from 18dd465 to 0c9113c Compare December 7, 2024 08:09
@wakeful
Copy link
Contributor Author

wakeful commented Dec 7, 2024

@wakeful, do you want to update the branch?

hey @james03160927
rebase done!

Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james03160927 james03160927 merged commit 485b3e0 into gruntwork-io:main Dec 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestTerraformAwsRdsExample/mysql UnitTest Failure
2 participants