Upgrade github.com/hashicorp/go-getter to v2 for remove indirect github.com/aws/aws-sdk-go reference #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/opa/download_policy.go
Outdated
| return "", err | ||
| } | ||
| policyDirCache.Store(baseDir, tempDir) | ||
| return filepath.Join(tempDir, subDir), nil | ||
| } | ||
|
|
||
| // detectGetter find suitable getter.Getter by rulePath. | ||
| func detectGetter(rulePath string) (getter.Getter, error) { |
There was a problem hiding this comment.
Would you please create unit test for this change to make sure we can continue to validate whether this code works going forward and now?
There was a problem hiding this comment.
I thought about it a bit and rewrote the patch. This variant should be more straightforward.
modules/opa/download_policy.go
Outdated
| return "", err | ||
| } | ||
| policyDirCache.Store(baseDir, tempDir) | ||
| return filepath.Join(tempDir, subDir), nil | ||
| } | ||
|
|
||
| // detectGetter find suitable getter.Getter by rulePath. |
There was a problem hiding this comment.
Can you elaborate what this mean? What does it mean to find suitable getter.Getter?
…ub.com/aws/aws-sdk-go reference
bozaro
force-pushed
the
remove-indirect-aws-sdk-go-dependency
branch
from
e80656b to
03b2bd3
Compare
james03160927
approved these changes
Dec 5, 2024
denis256
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #1432.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Upgrade github.com/hashicorp/go-getter to v2.
Migration Guide