JSON output fetching fixes #1462
Conversation
|
terraform-aws-ci tests are passing too
|
modules/terraform/cmd.go
Outdated
| } | ||
| _, tgLogSet := options.EnvVars["TERRAGRUNT_DISABLE_LOG_FORMATTING"] | ||
| if !tgLogSet { | ||
| options.EnvVars["TERRAGRUNT_DISABLE_LOG_FORMATTING"] = "true" |
There was a problem hiding this comment.
This env var is deprecated, please use TERRAGRUNT_LOG_FORMAT=key-value
*But only if you use the latest version that supports log format.
modules/terraform/output.go
Outdated
|
|
||
| var ( | ||
| ansiLineRegex = regexp.MustCompile(`(?m)^\x1b\[[0-9;]*m.*`) | ||
| tgLogLevel = regexp.MustCompile(`.*time=\S+ level=\S+ prefix=\S+ binary=\S+ msg=.*`) |
There was a problem hiding this comment.
You can use TERRAGRUNT_LOG_CUSTOM_FORMAT="%msg(color=disable)" to get rid of cleanJson function at all.
*But only if you use the latest version that supports custom log format.
There was a problem hiding this comment.
Output still has lines like:
time=2024-12-05UTC17:32:10Z level=stdout tf-path=terraform msg=Initializing the backend...
which requires cleaning when parsing output
| } | ||
| _, tgLogSet := options.EnvVars["TERRAGRUNT_LOG_FORMAT"] | ||
| if !tgLogSet { | ||
| options.EnvVars["TERRAGRUNT_LOG_FORMAT"] = "key-value" |
There was a problem hiding this comment.
Can you explain what this does? It could be great to add some comments explanining the default behaviour here and below.
| const skipJsonLogLine = " msg=" | ||
|
|
||
| var ( | ||
| ansiLineRegex = regexp.MustCompile(`(?m)^\x1b\[[0-9;]*m.*`) |
There was a problem hiding this comment.
nit: can we add comments on what these regex mean in plain English?
Description
Included changes:
Fixes #1453.
Fixes #1461.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
Updated output parsing from Terragrunt
Migration Guide