Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Route53 #1421

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Add Route53 #1421

merged 2 commits into from
Jul 23, 2024

Conversation

james03160927
Copy link
Contributor

Description

Fixes #1407

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@james03160927 james03160927 requested a review from denis256 as a code owner July 20, 2024 23:37
denis256
denis256 reviewed Jul 22, 2024
View reviewed changes
modules/aws/route53.go Outdated Show resolved Hide resolved
modules/aws/route53.go Show resolved Hide resolved
modules/aws/route53.go Outdated Show resolved Hide resolved
@james03160927
Copy link
Contributor Author

Addressed your comments. PTAL @denis256

@james03160927 james03160927 merged commit 5a79983 into master Jul 23, 2024
2 of 3 checks passed
@james03160927 james03160927 deleted the route53 branch July 23, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis256 denis256 denis256 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add AWS Route53
2 participants
@james03160927 @denis256