Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why binary included in example AWS lambda? #1363

Closed
lmmarsano opened this issue Oct 30, 2023 · 0 comments · Fixed by #1470
Closed

Why binary included in example AWS lambda? #1363

lmmarsano opened this issue Oct 30, 2023 · 0 comments · Fixed by #1470
Labels
bug Something isn't working

Comments

@lmmarsano
Copy link

lmmarsano commented Oct 30, 2023 •
edited
Loading

Describe the bug
Security scanners like JFrog Xray find a large number of vulnerabilities (around 60) because of this 3 year old binary.
https://github.com/gruntwork-io/terratest/blame/1f1821ea7907875eca48592df99ea3d92bfa0888/examples/terraform-aws-lambda-example/src/lambda

Why is it here?
Gross.

To Reproduce
Visit
https://github.com/gruntwork-io/terratest/blame/1f1821ea7907875eca48592df99ea3d92bfa0888/examples/terraform-aws-lambda-example/src/lambda

Ponder questions.

Expected behavior
Not commit a binary to version control.
The source code should suffice.

Versions

  • Terratest version: 0.46.1
  • Environment details (Ubuntu 20.04, Windows 10, etc.): any
@lmmarsano lmmarsano added the bug Something isn't working label Oct 30, 2023
wakeful added a commit to wakeful/terratest that referenced this issue Nov 13, 2024
@wakeful
fix gruntwork-io#1363 build lambda bin from src instead using a blob …
9ff9cd1 
…+ bump ext pkg.
@wakeful wakeful mentioned this issue Nov 13, 2024
Merged
5 tasks
wakeful added a commit to wakeful/terratest that referenced this issue Nov 19, 2024
@wakeful
fix gruntwork-io#1363 build lambda bin from src instead using a blob …
0a3656a 
…+ bump ext pkg.
yhakbar added a commit that referenced this issue Nov 19, 2024
@yhakbar
Merge pull request #1470 from wakeful/bump-aws-lambda-pkg-rm-bin-from…
ce008dc 
…-dvcs

fix #1363 build lambda bin from src instead using a blob + bump ext pkg.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #1363 build lambda bin from src instead using a blob + bump ext pkg. wakeful/terratest
1 participant
@lmmarsano