accept a function for sourceMapURL #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@montmanu: can you rebase? |
|
|
XhmikosR
requested changes
Mar 12, 2017
tasks/less.js
Outdated
| } | ||
| } | ||
|
|
||
| if (_.isBoolean(options.sourceMap) && options.sourceMap) { |
Member
There was a problem hiding this comment.
typeof options.sourceMap === 'boolean'
XhmikosR
reviewed
Mar 12, 2017
tasks/less.js
Outdated
| } | ||
| } | ||
|
|
||
| if (_.isFunction(options.sourceMapURL)) { |
Member
There was a problem hiding this comment.
Isn't typeof options.sourceMapURL === 'function' enough here?
Contributor
Author
There was a problem hiding this comment.
probably. just figured since lodash had already been imported, would use that utility. would you prefer typeof ?
Member
There was a problem hiding this comment.
I was just trying to decouple of lodash and just keep stuff we only need.
Contributor
Author
There was a problem hiding this comment.
ok, cool. will update with typeof here and in the other PR.
XhmikosR
approved these changes
Mar 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.