[#121] Improve sourceMap performance #137
Merged
+111
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writes the files directly to a source map generator removing a bunch of intermediate steps performed when converting between nodes to a generator. On my laptop this brings the concat step of my build down from ~6m to under 10s. The current implementation does not seem to add mappings before filler lines (banner, separator and footer) in a consistent manner so this never adds a mapping for the filler text.
BrentDouglas
force-pushed
the
121-sourcemap-perf
branch
from
2f32a92 to
e396d41
Compare
|
This fix made a big performance improvement for me. +1 |
|
@BrentDouglas nice work, tried it locally and it sped things up quite a bit. 👍 |
|
@XhmikosR any ideas on when this can be merged? really speeds things up |
|
+1 I'd also like to see this merged and a new release |
vladikoff
added a commit
that referenced
this pull request
Feb 11, 2016
[#121] Improve sourceMap performance
|
👍 |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writes the files directly to a source map generator removing a bunch of intermediate steps performed when converting between nodes to a generator.
On my laptop this brings the concat step of my build down from ~6m to under 10s.
The current implementation does not seem to add mappings before filler lines (banner, separator and footer) in a consistent manner so this never adds a mapping for the filler text.