Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #27

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Cleanup #27

merged 1 commit into from
Feb 1, 2023

Conversation

yukibtc
Copy link
Contributor

@yukibtc yukibtc commented Feb 1, 2023

  • Replace nostr-sdk with nostr (nostr-sdk contains unnecessary code for this library)
  • Remove unnecessary dependencies
  • General cleanup

@yukibtc yukibtc force-pushed the cleanup branch 7 times, most recently from d4ba02c to 103278f Compare February 1, 2023 17:19
@yukibtc yukibtc marked this pull request as ready for review February 1, 2023 17:25
Remove unnecessary dependencies
General cleanup
Copy link
Owner

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@grunch grunch merged commit cfd96f4 into grunch:main Feb 1, 2023
@yukibtc yukibtc deleted the cleanup branch February 1, 2023 20:22
@schlunsen
Copy link
Contributor

Thanks @yukibtc! Learned a thing or two by reading the changes

@grunch
Copy link
Owner

grunch commented Feb 2, 2023

yeah same to me, learned a lot with those changes, thanks again

@yukibtc
Copy link
Contributor Author

yukibtc commented Feb 2, 2023

Glad I was helpful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants