Properly adjusting hi16's addend relocation.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Jan 26, 2024 in 34s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method psyq-obj-parser.cc: PsyqLnkFile::Relocation::generateElf
Annotations
Check notice on line 1 in tools/psyq-obj-parser/psyq-obj-parser.cc
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Lines of Code in a Single File
The lines of code increases from 1172 to 1176, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check warning on line 1344 in tools/psyq-obj-parser/psyq-obj-parser.cc
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
PsyqLnkFile::Relocation::generateElf increases in cyclomatic complexity from 54 to 55, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in tools/psyq-obj-parser/psyq-obj-parser.cc
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 12.00 to 12.05, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Loading