Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break up is_supported check into parsing and evaluating steps #149

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Break up is_supported check into parsing and evaluating steps #149

merged 1 commit into from
Jan 28, 2025

Conversation

sergiitk
Copy link
Member

Separates evaluate_test_config into parse_lang_spec_from_flags and evaluate_is_supported so that custom override logic can be inserted between them.

This change exposed a bug with cls.lang_spec.server_lang getting out of sync with cls.server_image when the image is overridden in suite's setUpClass().

@sergiitk sergiitk requested a review from a team as a code owner January 25, 2025 00:42
@sergiitk
Copy link
Member Author

sergiitk commented Jan 25, 2025 •
edited
Loading

@sergiitk sergiitk merged commit 54f9282 into grpc:main Jan 28, 2025
6 checks passed
@sergiitk sergiitk deleted the fix-test-config-todo branch January 28, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuanWang-Amos XuanWang-Amos XuanWang-Amos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergiitk @XuanWang-Amos