Skip to content

A94 update: simplify language for inflight connections #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markdroth merged 1 commit into from
Dec 8, 2025
Merged

A94 update: simplify language for inflight connections #526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions A94-subchannel-otel-metrics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
(@dfawley)
* Status: Ready for Implementation
* Implemented in:
* Last updated: 2025-11-14
* Last updated: 2025-12-08
* Discussion at: https://groups.google.com/g/grpc-io/c/iMdK7r4E5tU

## Abstract
Expand Down Expand Up @@ -58,9 +58,8 @@ grpc.subchannel.connection_attempts_succeeded (Old - grpc.lb.pick_first.connecti
grpc.subchannel.connection_attempts_failed (Old - grpc.lb.pick_first.connection_attempts_failed) | Counter | {attempt} | grpc.target, grpc.lb.backend_service (optional), grpc.lb.locality (optional) | Number of failed connection attempts.
grpc.subchannel.open_connections | UpDown Counter | {connection} | grpc.target, grpc.security_level (optional), grpc.lb.backend_service (optional), grpc.lb.locality (optional) | Number of open connections.

If we end up discarding connection attempts as we do with the “happy eyeballs”
algorithm (as per [A61]), we should not record the connection attempt or the
disconnection.
If the subchannel is shut down while a connection attempt is in flight, we
should not record the connection attempt as either succeeded or failed.

Implementations that have already implemented the pick-first metrics should give
enough time for users to transition to the new metrics. For example,
Expand Down