A2 update: Specify "_grpc_config." prefix for DNS name. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdroth
requested review from
lyuxuan,
ejona86,
carl-mastrangelo,
apolcyn and
a11r
fengli79
approved these changes
Nov 10, 2017
A2-service-configs-in-dns.md
Outdated
| The implementation has been done in C-core as part of the c-ares DNS | ||
| resolver. We are currently working toward making the c-ares resolver | ||
| the default DNS resolver for C-core. This requires things like Windows | ||
| and node support and adding address sorting. |
There was a problem hiding this comment.
s/node/Node
And why node is special here? Does it use c-core?
There was a problem hiding this comment.
Done.
We are in the process of working on a native javascript implementation for Node, but the comment here refers to Node support in C-core. There are some issues related to using c-ares with Node that we still need to work on.
ejona86
approved these changes
Nov 10, 2017
carl-mastrangelo
approved these changes
Nov 10, 2017
apolcyn
approved these changes
Nov 10, 2017
markdroth
force-pushed
the
service_config_dns_prefix
branch
2 times, most recently
from
915f5a4 to
58899db
Compare
Also a couple of other updates: - Fix quote character used in JSON. - Update information on C-core implementation.
markdroth
force-pushed
the
service_config_dns_prefix
branch
from
58899db to
b25ab3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a couple of other updates: