[Aio] Call correctly the connect CB error when an error happens#21543
[Aio] Call correctly the connect CB error when an error happens#21543pfreixes merged 1 commit intogrpc:masterfrom Skyscanner:allow_calling_none_existing_servers
Conversation
pfreixes
added
lang/Python
release notes: yes
| '/grpc.testing.TestService/UnaryCall', | ||
| request_serializer=messages_pb2.SimpleRequest.SerializeToString, | ||
| response_deserializer=messages_pb2.SimpleResponse.FromString, | ||
| ) |
There was a problem hiding this comment.
optional: switch to using our generated Stub.
There was a problem hiding this comment.
We haven't been using any stub in any of the tests of the test suite, should we start using them?
Or let's use them only once we start giving support/coverage for using the stubs through the Aio module?
| @@ -62,21 +61,15 @@ async def test_unary_unary(self): | |||
| self.assertIsInstance(response, messages_pb2.SimpleResponse) | |||
|
|
|||
| async def test_unary_call_times_out(self): | |||
There was a problem hiding this comment.
nit: We could have a time out test case for succeed RPC just like before. You could refer to server_test.py. Not a blocker for this PR.
There was a problem hiding this comment.
The only "problem" is that our test suite for the client is quite coupled to the basic proto stub test_pb2_grpc.py, so any change in functionality for any method could change the desired semantic, the same that happened with the EmptyCall method.
This is a recurrent question, should we decouple the test suite from that file, so no longer using it, and use our own one? or even better, use our one server fixture based on a programmatic RPC handlers builder, the same that is being used for testing the current Aio server.
Fixes a bug with the Aio socket that did not call correctly the connect CB function when there was an issue connecting to a host
4 participants
Fixes a bug with the Aio socket that did not call correctly the
connect CB function when there was an issue connecting to a host
Issue related: #20818
Also fixes #20869 by removing the usage of timeout by calling invalid hosts.