This repository has been archived by the owner on Apr 9, 2021. It is now read-only.
Update to account for import error in generated python code #671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After generating relevant server/client code for python, the presence of
causes,
pip install grpcio-tools
only brings ingoogle/protobuf
module.Installing
googleapis-common-protos
causes the required files, specifically,google/api/annotations_pb2.py
to be pulled in, thus resolving the import error.There are examples like python-grpc-hack.sh out there, which is basically hacking
around the absence of the required module. I have not yet tried the Java codegen yet
but till the relevant protoc changes are pushed upstream, this change seems to be
the path of least resistance.
What are your thoughts around this?
Related issue: #298.
Signed-off-by: Debosmit Ray [email protected]