Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Watch method to health checking service. #33

Merged
merged 2 commits into from
Aug 14, 2018
Merged

Add Watch method to health checking service. #33

merged 2 commits into from
Aug 14, 2018

Conversation

markdroth
Copy link
Member

No description provided.

ejona86
ejona86 approved these changes Aug 13, 2018
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably instruct clients what to do if they receive status OK.

@markdroth markdroth mentioned this pull request Aug 14, 2018
Merged
@markdroth
Copy link
Member Author

Added a comment about how to handle call termination. PTAL.

@markdroth markdroth merged commit 9b13d19 into grpc:master Aug 14, 2018
@markdroth markdroth deleted the health_check_watch_method branch August 14, 2018 16:20
@carl-mastrangelo
Copy link
Contributor

@markdroth can you import this change internally? There should be a script for you to use.

@dfawley dfawley mentioned this pull request Jun 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejona86 ejona86 ejona86 approved these changes

@dfawley dfawley Awaiting requested review from dfawley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markdroth @carl-mastrangelo @ejona86