Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move dependencies around, add gulp target for document generation #46

Merged
merged 5 commits into from
Sep 29, 2017
Merged

Move dependencies around, add gulp target for document generation #46

merged 5 commits into from
Sep 29, 2017

Conversation

murgatroid99
Copy link
Member

This is the convention I'm following for dependencies:

  • For the packages, "dependencies" have runtime dependencies, and "devDependencies" have test dependencies.
  • For the root package, "devDependencies" have scripting dependencies (i.e. stuff that is used in gulpfiles).
  • For the test package, "dependencies" contain runtime test dependencies.

This PR doesn't entirely complete that. The istambul dependency is still in the native package because of SBoudrias/gulp-istanbul#118.

@murgatroid99 murgatroid99 merged commit d4bf495 into grpc:master Sep 29, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kjin kjin kjin approved these changes

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murgatroid99 @kjin