Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loadPackageDefinition and interceptor APIs to .d.ts file #306

Merged

Conversation

murgatroid99
Copy link
Member

The issue with loadPackageDefinition was pointed out in #189.

@nicolasnoble
Copy link
Member

I guess we don't really have tests for this yet, due to #220 not being merged in ?

@murgatroid99
Copy link
Member Author

We don't have tests for this anyway, because this is type definitions for the old library, not the new one.

@murgatroid99 murgatroid99 merged commit 0631ee7 into grpc:v1.11.x May 2, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants