grpc-js-xds: interop server: Add support for sending custom metrics #3008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emil10001
approved these changes
Sep 12, 2025
Member
emil10001
left a comment
emil10001
left a comment
There was a problem hiding this comment.
Overall looks good. I see that there are a few tests failing. Windows actually looked like everything passed, unless I missed something. But, for node 20 and 22, there were a couple of failures that might be worth checking on.
Member
Author
|
Yeah, the Windows tests have been broken for a while. I'm confident that those failures are unrelated to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds command line options to configure what metrics to send and how to send them, and the functionality to do so, as described in grpc/grpc#40630. This will be used to test the client side weighted round robin LB policy.